Google Groups Home
Help | Sign in
CCTray abort supposed to cause project failure?
There are currently too many topics in this group that display first. To make this topic appear first, remove this option from another topic.
There was an error processing your request. Please try again.
flag
  9 messages - Collapse all
The group you are posting to is a Usenet group. Messages posted to this group will make your email address visible to anyone on the Internet.
Your reply message has not been sent.
Your post was successful
 
From:
To:
Cc:
Followup To:
Add Cc | Add Followup-to | Edit Subject
Subject:
Validation:
For verification purposes please type the characters you see in the picture below or the numbers you hear by clicking the accessibility icon. Listen and type the numbers you hear
 
JDAVIDI  
View profile
 More options Aug 29 2008, 8:47 am
From: JDAVIDI <jda...@infodir.com>
Date: Fri, 29 Aug 2008 05:47:54 -0700 (PDT)
Local: Fri, Aug 29 2008 8:47 am
Subject: CCTray abort supposed to cause project failure?
Greetings,

Below is a log snippet from when I issued an Abort Build to when it
aborted.

I was expecting the project to remain in its previous 'successful'
state (akin to killing the ccnet.exe console), but instead the project
flipped to a failure state and ended up emailing the engineers on the
last modification list with no errors listed or any indication of the
abort.

Is this behavior by design, or did it happen to be caused by where the
the project was (mid-Visual Studio build) when the abort was
processed?

Thank you,

--jdavidi

2008-08-29 08:21:50,739 [5532:INFO] jdav aborted the running Build for
project: CruiseControl 9.04 Base RateBill
2008-08-29 08:21:51,320 [CruiseControl 9.04 Base RateBill:DEBUG]
2008-08-29 08:21:51,330 [CruiseControl 9.04 Base RateBill:DEBUG]
Microsoft (R) Visual Studio Version 8.0.50727.762.
2008-08-29 08:21:51,330 [CruiseControl 9.04 Base RateBill:DEBUG]
Copyright (C) Microsoft Corp 1984-2005. All rights reserved.
2008-08-29 08:21:51,330 [CruiseControl 9.04 Base RateBill:DEBUG]
------ Rebuild All started: Project: DBLibrary, Configuration: Debug
Win32 ------
2008-08-29 08:21:51,330 [CruiseControl 9.04 Base RateBill:DEBUG]
Deleting intermediate and output files for project 'DBLibrary',
configuration 'Debug|Win32'
2008-08-29 08:21:53,212 [5532:INFO]
------------------------------------------------------------------
2008-08-29 08:21:53,212 [5532:INFO] ---------The Build Process was
successfully aborted---------------
2008-08-29 08:21:53,212 [5532:INFO]
------------------------------------------------------------------
2008-08-29 08:21:53,232 [CruiseControl 9.04 Base RateBill:INFO] Task
execution failed
2008-08-29 08:21:53,232 [CruiseControl 9.04 Base RateBill:INFO] Task
output:
Microsoft (R) Visual Studio Version 8.0.50727.762.
Copyright (C) Microsoft Corp 1984-2005. All rights reserved.
------ Rebuild All started: Project: DBLibrary, Configuration: Debug
Win32 ------
Deleting intermediate and output files for project 'DBLibrary',
configuration 'Debug|Win32'

2008-08-29 08:21:53,232 [CruiseControl 9.04 Base RateBill:INFO] Devenv
build complete.  Status: Failure
2008-08-29 08:21:53,453 [CruiseControl 9.04 Base RateBill:INFO]
Emailing "CruiseControl 9.04 Base RateBill Build Failed" to
x...@yyy.com, x...@yyy.com
2008-08-29 08:21:53,573 [CruiseControl 9.04 Base RateBill:INFO]
Integration complete: Failure - 8/29/2008 8:21:53 AM
2008-08-29 08:21:53,683 [CruiseControl 9.04 Base RateBill:INFO]
Integrator for project: CruiseControl 9.04 Base RateBill is now
stopped.


    Reply to author    Forward  
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Daniel Hommel  
View profile
 More options Aug 29 2008, 9:20 am
From: Daniel Hommel <daniel.hom...@it-designers.de>
Date: Fri, 29 Aug 2008 15:20:21 +0200
Local: Fri, Aug 29 2008 9:20 am
Subject: Re: CCTray abort supposed to cause project failure?
The logic behind the "Abort Build" feature is that an aborted build is a
failed build (it got aborted because it would have failed otherwise).
I'm not sure if this is the best solution, maybe this needs some
discussion. At least it should add an error to the log telling that the
project got aborted...

Should an aborted build make the project fail or should it stay in it's
last successful state? Or should there be a way to configure the behavior?

Any further comments appreciated.

regards,

Daniel


    Reply to author    Forward  
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Ross Patterson  
View profile
 More options Aug 29 2008, 9:21 am
From: "Ross Patterson" <ross.patter...@gmail.com>
Date: Fri, 29 Aug 2008 09:21:13 -0400
Local: Fri, Aug 29 2008 9:21 am
Subject: Re: [ccnet-user] CCTray abort supposed to cause project failure?

On Fri, Aug 29, 2008 at 08:47, JDAVIDI <jda...@infodir.com> wrote:
> Below is a log snippet from when I issued an Abort Build to when it
> aborted.

> I was expecting the project to remain in its previous 'successful'
> state (akin to killing the ccnet.exe console), but instead the project
> flipped to a failure state and ended up emailing the engineers on the
> last modification list with no errors listed or any indication of the
> abort.

> Is this behavior by design, or did it happen to be caused by where the
> the project was (mid-Visual Studio build) when the abort was
> processed?

I wouldn't go so far as to say it's by design, but it certainly is the way
CCNet works.  The build has already started and must have a final status,
and builds either succeed or fail - there is no in-between state.  I'll
grant that the abort code should include an error to the effect that the
build failed because it was aborted, rather than just being quiet.

Ross


    Reply to author    Forward  
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
JDAVIDI  
View profile
 More options Aug 29 2008, 11:03 am
From: JDAVIDI <jda...@infodir.com>
Date: Fri, 29 Aug 2008 08:03:51 -0700 (PDT)
Local: Fri, Aug 29 2008 11:03 am
Subject: Re: CCTray abort supposed to cause project failure?
On Aug 29, 9:20 am, Daniel Hommel <daniel.hom...@it-designers.de>
wrote:

> The logic behind the "Abort Build" feature is that an aborted build is a
> failed build (it got aborted because it would have failed otherwise).

On Aug 29, 9:21 am, "Ross Patterson" <ross.patter...@gmail.com> wrote:

> On Fri, Aug 29, 2008 at 08:47, JDAVIDI <jda...@infodir.com> wrote:
> The build has already started and must have a final status,
> and builds either succeed or fail - there is no in-between state.

Ah, OK, I accept these rationales; I was aborting in this case only
because I wanted to force build another project in the same queue that
someone was anxious to get.  I can stick to the ccnet.exe process
termination that I used throughout the 1.3 implementation for these
types of situations.  But the minor addition of a "failed due to
[user] abort" to any published email/log definitely has my vote.

Thanks as always for the quick insight!

--jdavidi


    Reply to author    Forward  
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Ross Patterson  
View profile
 More options Aug 29 2008, 11:10 am
From: "Ross Patterson" <ross.patter...@gmail.com>
Date: Fri, 29 Aug 2008 11:10:14 -0400
Local: Fri, Aug 29 2008 11:10 am
Subject: Re: [ccnet-user] Re: CCTray abort supposed to cause project failure?

On Fri, Aug 29, 2008 at 11:03, JDAVIDI <jda...@infodir.com> wrote:
> But the minor addition of a "failed due to
> [user] abort" to any published email/log definitely has my vote.

FYI, the easiest way to ensure that a change like this one gets made is to
open a problem ticket for it at
http://jira.public.thoughtworks.org/secure/CreateIssue!default.jspa<http://jira.public.thoughtworks.org/secure/CreateIssue%21default.jspa>.
Since the CCNET release notes are built automatically from the resolved
tickets, there has to be one anyway.

Ross


    Reply to author    Forward  
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Daniel Hommel  
View profile
 More options Sep 2 2008, 5:55 pm
From: Daniel Hommel <daniel.hom...@it-designers.de>
Date: Tue, 02 Sep 2008 23:55:08 +0200
Local: Tues, Sep 2 2008 5:55 pm
Subject: Re: CCTray abort supposed to cause project failure?

Ross Patterson writes:
> I wouldn't go so far as to say it's by design, but it certainly is the
> way CCNet works.  The build has already started and must have a final
> status, and builds either succeed or fail - there is no in-between
> state.  I'll grant that the abort code should include an error to the
> effect that the build failed because it was aborted, rather than just
> being quiet.

> Ross

While investigating on this i found out that it seems to be the easiest
way to fix the mentioned behavior to pull the RunnableProcess class out
of the ProcessExecutor class and also use it in the ProcessMonitor
instead of using the Process class directly. If that's not a problem i
think i can provide a patch.

regards,

Daniel


    Reply to author    Forward  
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Daniel Hommel  
View profile
 More options Sep 4 2008, 7:09 am
From: Daniel Hommel <daniel.hom...@it-designers.de>
Date: Thu, 04 Sep 2008 13:09:51 +0200
Local: Thurs, Sep 4 2008 7:09 am
Subject: Re: CCTray abort supposed to cause project failure?

I tried to insert an error message in the standard error output of the
executable which is passed to the ProcessResult class. It is working for
the executable task and the nant task since they don't use a logger like
the msbuild task does and both use the same XML format (seems like
msbuild is the only task that doesn't).

With the msbuild task i see two options. The first option would be to
merge the output of the logger AND the ProcessResult transformed into
XML. A drawback is that you see each error or warning 2 times in the
build report page (could be fixed). The second option would be to
somehow insert the error message in the XML file that the logger writes
before merging it.

A different and maybe the best approach would be to not insert the error
message in the ProcessResult and just throw an exception with a
meaningful message like the one that gets thrown when a timeout occurs.

Which way to go? I guess i'd prefer throwing an exception.

regards,

Daniel


    Reply to author    Forward  
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Dave Cameron  
View profile
 More options Sep 5 2008, 12:13 am
From: Dave Cameron <dave...@gmail.com>
Date: Fri, 5 Sep 2008 14:13:25 +1000
Local: Fri, Sep 5 2008 12:13 am
Subject: Re: [ccnet-user] Re: CCTray abort supposed to cause project failure?
On 04/09/2008, at 9:09 PM, Daniel Hommel <daniel.hommel@it-

Throwing an exception sounds very simple. So I like it for that reason.

We're using bamboo on my current project and have been killing a lot  
of builds. It has been quite useful to see what happened in the build  
up until the kill. If you use the exception approach will the build  
log show the activity up until that point?

Dave


    Reply to author    Forward  
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Daniel Hommel  
View profile
 More options Sep 5 2008, 7:53 am
From: Daniel Hommel <daniel.hom...@it-designers.de>
Date: Fri, 05 Sep 2008 13:53:09 +0200
Local: Fri, Sep 5 2008 7:53 am
Subject: Re: CCTray abort supposed to cause project failure?
Dave Cameron schrieb:

Didn't try that yet, but my goal is to get this behavior. I think it
depends on where we throw the exception.

regards,

Daniel


    Reply to author    Forward  
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
End of messages
« Back to Discussions « Newer topic     Older topic »

Create a group - Google Groups - Google Home - Terms of Service - Privacy Policy
©2009 Google