ccnet-devel Google Group

Messaging and communications

cj.sutherl...@xtra.co.nz (Craig Sutherland) — Sun, 04 Jan 2009 19:43:33 UT

Hello all,

Yesterday Dave identified a limitation with some of my recent changes.
Because they require new parameters to some of the interfaces, this
has a large flow-on affect to many other interfaces and classes. He
also suggested a solution, which I think would work very nicely.

However, considering this will be a major change in the way

Re: Security Branch

john.man...@gmail.com (johnman) — Sun, 04 Jan 2009 10:25:50 UT

Hi David,

I'd be interested in testing out the RC of the security branch when it
is available.

Cheers,

John

Re: [ccnet-devel] Re: SF.net SVN: ccnet:[4523] branches/security/project

dave...@gmail.com (David Cameron) — Sun, 04 Jan 2009 06:50:11 UT

Considering how many files it touches, at least right now, I'd like to
save it for 1.5 so it can get more testing. I know "files touched" is
a very crude measure, but it's also one that is immediately obvious.
Dave Cameron
CruiseControl.NET - [link]
On Sun, Jan 4, 2009 at 5:39 PM, Craig & Sammi Sutherland

RE: [ccnet-devel] Re: SF.net SVN: ccnet:[4523] branches/security/project

cj.sutherl...@xtra.co.nz (Craig & Sammi Sutherland) — Sun, 04 Jan 2009 06:39:46 UT

Hi Dave,
Thanks for the feedback. Your idea of a build-request object is brilliant!
It would definitely simple things moving forward in the long-term and allow
us to simplify the interfaces (it's the sort of idea I was I had thought
of!)
As a side-note, I have added this to the security branch, rather than the

Re: SF.net SVN: ccnet:[4523] branches/security/project

dave...@gmail.com (David Cameron) — Sun, 04 Jan 2009 06:31:26 UT

Nice work Craig.
The number of fiels that needs to change is a black mark against the
CCNet design. I think there is an opportunity to wrap up some sort of
build-request object and pass that around, rather than having to
change method signatures through so many interfaces?
This is more of a long term change, and doesn't need to affect this

Re: [ccnet-devel] Security Branch

dave...@gmail.com (David Cameron) — Sat, 03 Jan 2009 04:40:25 UT

Hi
There are enough changes on trunk for another release. I think we
should make a 1.4.3 release in January.
The security branch changes would make for a 1.5 release sometime
after January. John do you have the time and interest to try the
security changes when a release candidate is available?
Dave Cameron

Re: [ccnet-devel] Security Branch

ruben.will...@gmail.com (Ruben Willems) — Fri, 02 Jan 2009 17:52:00 UT

Hi
I'm testing it also, and am working together with Craig to iron out some
small issues,
(documentation for instance). An exact timeline is not known yet :-(
but I expect the merge to appear the next weeks, when the holidays are over
;-)
with kind regards
Ruben Willems

Security Branch

john.man...@gmail.com (johnman) — Fri, 02 Jan 2009 11:31:22 UT

Hi All,

Is there a timeline for merging the security branch into the main
branch?

Thanks,

John

Re: [ccnet-devel] Re: issue 748 : Provide better trigger exception logging

ruben.will...@gmail.com (Ruben Willems) — Fri, 02 Jan 2009 09:22:40 UT

Hi
let me know if the latest patch works,
I'm now working on making it configurable, and have some idea on the posible
options.
Hopefully this is ready during the weekend.
Keeping you posted ...
with kind regards
Ruben Willems

Re: issue 748 : Provide better trigger exception logging

strefet...@gmail.com (Steve Trefethen) — Fri, 02 Jan 2009 07:33:16 UT

You're absolutely right. This occurred to me and when I returned here
to post again I found your response. :)

-Steve

Re: [ccnet-devel] Re: issue 748 : Provide better trigger exception logging

ruben.will...@gmail.com (Ruben Willems) — Thu, 01 Jan 2009 20:50:46 UT

Hi Steve
this fix will not work:
you will only run the publishers if a build occured,
but when an error occured at getmodifications, the publishers are not ran.
I'll try to fix this problem, it is indeed not needed to run the publishers
on every integration.
only when a build ran, or there was an error in getting the modifications.

source code available as a mercurial repository on bitbucket

dave...@gmail.com (David Cameron) — Thu, 01 Jan 2009 09:54:28 UT

I've wanted an offline copy of the ccnet repository for a while. Over
the past couple days I was able to use hgsubversion[1] to create a
local repository with the full project history. This afternoon, I
uploaded it to BitBucket. If you'd like to clone a mercurial
repository for yourself, you can do it from bitbucket at

Re: issue 748 : Provide better trigger exception logging

strefet...@gmail.com (Steve Trefethen) — Wed, 31 Dec 2008 21:48:00 UT

Hi Ruben,
So this patch will *always* call PostBuild() regardless of
result.ShouldRunBuild() which is a serious problem.

Here is my modification to IntegrationRunner.cs
IntegrationRunner.Integration( ...) to fix this problem. These changes
more closely mirror the previous code with respect to the result of

Re: issue 748 : Provide better trigger exception logging

strefet...@gmail.com (Steve Trefethen) — Wed, 31 Dec 2008 21:23:23 UT

Just a quick heads up as it looks like I spoke too soon as the patch
causes problems with the project integration. If I run a project it
*always* complete integration regardless of whether or not there were
modifications thus triggering whatever publishers are active.

I haven't determined the cause yet but this patch definitely breaks

Re: issue 748 : Provide better trigger exception logging

strefet...@gmail.com (Steve Trefethen) — Tue, 30 Dec 2008 22:39:08 UT

Hi Ruben,
I saw the call to Stopped() which I've commented out for now in my
build. I played around with the restart options and found the things
you mentioned to work accordingly.

Thanks again,
-Steve